Better handling of slightly messy prod data #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better handling of slightly messy prod data
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (value instanceof Date) { | ||
| return value | ||
| } | ||
| if (typeof value === 'object') { |
There was a problem hiding this comment.
[correctness]
Using _.mapValues on an object without checking if it's a plain object can lead to unexpected behavior if value is an instance of a class or has a prototype chain. Consider using _.isPlainObject to ensure value is a plain object before mapping its values.
| result = _.filter(result, (item) => _.includes(config.MEMBER_PUBLIC_TRAITS, item.traitId)) | ||
| } | ||
| return result | ||
| return helper.convertBigIntDeep(result) |
There was a problem hiding this comment.
[correctness]
Ensure that helper.convertBigIntDeep is correctly handling all possible data structures within result. If result contains nested objects or arrays, verify that convertBigIntDeep can process them without errors or unintended modifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.